[poppler] ReqForTest: remove extra fontconfig includes/linking

Pino Toscano pino at kde.org
Sun Jul 15 13:24:43 PDT 2012


Alle domenica 15 luglio 2012, Albert Astals Cid ha scritto:
> El Diumenge, 15 de juliol de 2012, a les 18:18:25, Pino Toscano va 
> escriure:
> > Hi,
> > 
> > commit 29366d8e470ab2207cdfdab115c2fa9618c4c74e added the
> > fontconfig cflags and libs everywhere outside of the poppler/
> > directory; this was mainly because GlobalParams.h used to include
> > fontconfig.h, until c804db4d8261274b013f8c340abfc921c77bb3cf.
> > Now it seems those fontconfig cflags and libs in frontends and
> > utils can be removed, since fontconfig now is used only on
> > GlobalParams.cc.
> > 
> > It seems to work for me with both autotools and cmake; feedback
> > from more people would be nice (so I can eventually push it to the
> > 0.20 branch, if Albert agrees).
> 
> Makes sense,

Ok, I'll wait for a bit more feedback (e.g. on Windows, or possibly 
other OSes or a-bit-dated Linux distros).

> also maybe you can remove
> WITH_FONTCONFIGURATION_FONTCONFIG from poppler/poppler-config.h.*
> since the define is not part of the unsupported installed headers
> anymore?

Ok, I can do that directly once this is done.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20120715/33555cec/attachment.pgp>


More information about the poppler mailing list