[poppler] poppler/Rendition.cc

Carlos Garcia Campos carlosgc at kemper.freedesktop.org
Wed Mar 7 09:37:26 PST 2012


 poppler/Rendition.cc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 508c7c3ef1f22459daa822f8287cab382119e753
Author: Tobias Koenig <tobias.koenig at kdab.com>
Date:   Wed Mar 7 18:35:05 2012 +0100

    Fix logic error in Rendition parsing code
    
    Make the rendition object invalid when both P an C entries are not
    present or are invalid in Media Rendition dictionary.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=47063

diff --git a/poppler/Rendition.cc b/poppler/Rendition.cc
index d00f555..c1b9a7e 100644
--- a/poppler/Rendition.cc
+++ b/poppler/Rendition.cc
@@ -344,7 +344,7 @@ MediaRendition::MediaRendition(Object* obj) {
       BE.parseMediaPlayParameters(&params);
     }
     params.free();
-  } else if (hasClip) {
+  } else if (!hasClip) {
     error (errSyntaxError, -1, "Invalid Media Rendition");
     ok = gFalse;
   }


More information about the poppler mailing list