[poppler] poppler and TeX Live -- request for a few modifications

[Albert Astals Cid]

El Dilluns, 19 de març de 2012, a les 11:09:09, Peter Breitenlohner va 
escriure:
> On Sun, 4 Mar 2012, Albert Astals Cid wrote:
> > El Divendres, 2 de març de 2012, a les 11:13:24, Peter Breitenlohner va
> > 
> > escriure:
> >> I just see that poppler-config.h in the brand new 0.19.0 now defines
> >> POPPLER_VERSION.  Thanks.  This is, however, #define'd as 0.19.0 and not
> >> as
> >> "0.19.0".  Is this a mistake or intentional?
> > 
> > This is intentional.
> 
> Albert,
> 
> please reconsider. For poppler-0.19.1 there are
>    cpp/poppler-version.h in the build tree, installed as
>    $(includedir)/poppler/cpp/poppler-version.h, with
>      #define POPPLER_VERSION "0.19.1"
>    and poppler/poppler-config.h in the build tree, installed as
>    $(includedir)/poppler/poppler-config.h, with
>      #ifndef POPPLER_VERSION
>      #define POPPLER_VERSION 0.19.1
>      #endif

That is only if you use the unsupported --enable-xpdf-headers option otherwise 
only the first file is installed and all is nice.

> 
> Thus POPPLER_VERSION is defined differently from <poppler-version.h> or from
> <poppler-config.h> (without <poppler-version.h>).  IMHO this is somewhat
> inconsistent.

Both headers are incompatible by definition, so that's not a problem.

Actually as I said you should not be using unsupported poppler internal 
headers, we've said this a million times, and you keep ignoring us.

And even if you ignore us, we are nice people and implement something 
specifically you need in the internal headers, but you do not check that our 
changes do what you want until months later of the code being added.

And even if all it takes for you is adding some simple quotes to fix your code 
you still argue we need to change the code.

If you really want this change and think it is so much better I think you 
could at least have sent the patch that implements the change.

Cheers,
  Albert

> 
> Regards
> Peter Breitenlohner <peb at mppmu.mpg.de>