[poppler] poppler and TeX Live -- request for a few modifications

[Peter Breitenlohner]

On Mon, 26 Mar 2012, Albert Astals Cid wrote:

> That is only if you use the unsupported --enable-xpdf-headers option otherwise
> only the first file is installed and all is nice.

I had missed this point.

> Actually as I said you should not be using unsupported poppler internal
> headers, we've said this a million times, and you keep ignoring us.

Yes, I know.  But this is not my decision, I am just integrating pdfTeX and
luaTeX into TeX Live.  Originally the respective developpers had used the
xpdf code for the inclusion of pdf images.  Next came the idea that distros
might prefer to use the shared poppler library - as one-to-one replacement. 
Finally the luaTeX developpers have decided that they always need poppler
but basically they still use the unsupported/deprecated xpdf headers.

So now we have a (somewhat stripped down) copy of poppler-0.18.4 in the TeX
Live source tree but distros may choose to use an installed version.

> And even if you ignore us, we are nice people and implement something
> specifically you need in the internal headers, but you do not check that our
> changes do what you want until months later of the code being added.

And we are grateful.  I am, however, not on this list and was not aware that
I should watch the git repository.  Thus I was waiting for poppler-0.19.0.

> And even if all it takes for you is adding some simple quotes to fix your code

I still don't understand this; a C program with
   #define POPPLER_VERSION 0.19.1
   printf ("%s\n", "POPPLER_VERSION");
will print 'POPPLER_VERSION' and not '0.19.1'.

> If you really want this change and think it is so much better I think you
> could at least have sent the patch that implements the change.

The required change was mentioned in my first mail from Oct 14, 2011,
a patch is now attached.

Regards
Peter
-------------- next part --------------
From 6d6cf3f61363778bf36485d66d62eda263e26871 Mon Sep 17 00:00:00 2001
From: Peter Breitenlohner <peb at mppmu.mpg.de>
Date: Mon, 26 Mar 2012 11:13:34 +0200
Subject: [PATCH] define POPPLER_VERSION as C string


Signed-off-by: Peter Breitenlohner <peb at mppmu.mpg.de>
---
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure.ac b/configure.ac
index 539dd17..ac3f026 100644
--- a/configure.ac
+++ b/configure.ac
@@ -41,7 +41,7 @@ dnl ##### Check for pkgconfig
 PKG_PROG_PKG_CONFIG
 
 dnl ##### Export the version
-AC_DEFINE([POPPLER_VERSION], [poppler_version], [Defines the poppler version])
+AC_DEFINE_UNQUOTED([POPPLER_VERSION], ["poppler_version"], [Defines the poppler version])
 
 dnl Enable these unconditionally.
 AC_DEFINE([OPI_SUPPORT], [1], [Generate OPI comments in PS output.])
-- 
1.7.3.1