[poppler] Small bug in SplashBitmap.cc for poppler-0.20.0

[Thomas Freitag]

Hi,

I got the attached hint from Anthony, and I agreed, so I created the 
attached one line patch.
Please insert the copyright notice of Anthony, I don't want to adorn 
myself with borrowed plumes :-)

Cheers,
Thomas

<http://www.dict.cc/englisch-deutsch/plumes.html>On 16.05.2012 06:48, 
Anthony Wesley wrote:
> Hi Thomas, hope you don't mind me emailing you direct about this, 
> there is a simple coding error in SplashBitmap.cc, in the function
>
> SplashError SplashBitmap::writeImgFile(ImgWriter *writer, FILE *f, int 
> hDPI, int vDPI)
>
> on line 522 (close to the end of the file) the test for error 
> condition on closing the writer is the wrong way around. The code 
> should say:
>
>  if (! writer->close()) {
>    return splashErrGeneric;
>  }
>
>
> as the code is currently written this function always returns 
> SplashErrorGeneric.
>
> regards, Anthony
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20120517/5817f0cb/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: writeImgFile.patch
Type: text/x-patch
Size: 361 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20120517/5817f0cb/attachment.bin>