[poppler] [PATCH] Fixes to building with recent versions of CMake and Ninja

Adam Reichold adam.reichold at t-online.de
Fri Dec 25 05:23:50 PST 2015


Hello,

after a recent upgrade of either CMake or Ninja, building with both the
Qt4 and Qt5 tests enabled started to fail. This seems to be caused by
CMake's automoc feature being broken due to the test targets being
present twice which Ninja does also complain about.

The attached patch tries to:
* Fix this by making the test target names unique for their Qt4 and Qt5
variants.
* Fix the warning on CMake policy 0022 by making use of the LINK_PRIVATE
flag.
* Make it possible to find OpenJPEG using pkg-config as well, i.e.
prefer a pkg-config manifest if one exits. (This is necessary for
example to build using CMake and OpenJPEG on Arch Linux.)

Best regards, Adam.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-cmake-ninja-build.patch
Type: text/x-patch
Size: 11658 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20151225/1d84bf93/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20151225/1d84bf93/attachment.sig>


More information about the poppler mailing list