[poppler] [PATCH] Fixes to building with recent versions of CMake and Ninja

Albert Astals Cid aacid at kde.org
Mon Dec 28 09:51:22 PST 2015


El Friday 25 December 2015, a les 14:23:50, Adam Reichold va escriure:
> Hello,
> 
> after a recent upgrade of either CMake or Ninja, building with both the
> Qt4 and Qt5 tests enabled started to fail. This seems to be caused by
> CMake's automoc feature being broken due to the test targets being
> present twice which Ninja does also complain about.
> 
> The attached patch tries to:
> * Fix this by making the test target names unique for their Qt4 and Qt5
> variants.
> * Fix the warning on CMake policy 0022 by making use of the LINK_PRIVATE
> flag.
> * Make it possible to find OpenJPEG using pkg-config as well, i.e.
> prefer a pkg-config manifest if one exits. (This is necessary for
> example to build using CMake and OpenJPEG on Arch Linux.)

The patch has conflicts in cmake/modules/FindLIBOPENJPEG.cmake:23 can you 
rebase it?

Cheers,
  Albert

> 
> Best regards, Adam.



More information about the poppler mailing list