[poppler] RFC: Expose whole-words search option in Qt frontends

[Albert Astals Cid]

El Dissabte, 10 de gener de 2015, a les 17:51:48, Adam Reichold va escriure:
> Hello,
> 
> Attach is a patch that would expose Poppler's whole-words search
> option within the Qt frontends.
> 
> While the implementation seems straight forward so far, I would like
> to request comments whether extending the "SearchMode" enumeration to
> flag definition is considered harmless. The proper way to do it seems
> to be the introduction of "QFlags<SearchMode>" which would however
> break compatibility and hence imply the need to have an additional
> overloads using a separate flag (and enumeration?) definition.

Looks good to me. The qt5/ side would need the documentation update too, no?

Cheers,
  Albert

> 
> Best regards, Adam.