[poppler] RFC: Expose whole-words search option in Qt frontends

Adam Reichold adam.reichold at t-online.de
Sat Jan 10 14:26:01 PST 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello again,

Am 10.01.2015 um 22:25 schrieb Albert Astals Cid:
> El Dissabte, 10 de gener de 2015, a les 17:51:48, Adam Reichold va
> escriure:
>> Hello,
>> 
>> Attach is a patch that would expose Poppler's whole-words search 
>> option within the Qt frontends.
>> 
>> While the implementation seems straight forward so far, I would
>> like to request comments whether extending the "SearchMode"
>> enumeration to flag definition is considered harmless. The proper
>> way to do it seems to be the introduction of "QFlags<SearchMode>"
>> which would however break compatibility and hence imply the need
>> to have an additional overloads using a separate flag (and
>> enumeration?) definition.
> 
> Looks good to me. The qt5/ side would need the documentation update
> too, no?

patch with fixed Qt5 documentation and "\since" commands attached.

Best regards, Adam.

> Cheers, Albert
> 
>> 
>> Best regards, Adam.
> 
> _______________________________________________ poppler mailing
> list poppler at lists.freedesktop.org 
> http://lists.freedesktop.org/mailman/listinfo/poppler
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJUsab1AAoJEPSSjE3STU34+LgH/jA0PKoylbSdEELNtqa1Nzv4
FD2HOs9uJnQmthwp/jODVw67OE22+ejyCiCjng6p/nKqv2Z33dEP/c+WzQzAYX8h
uXnZWtLLBi1lm9V2ZuJf8L/27UnYcCVzCBqSCdUaHPjxM//7HrSkG/f9DMBhQdpi
/m4aUAxT3eT5+zRhmKp9Ta15nnyaMych80LveU+Gff3/Iowt5QBtGDsfRnI6+/wX
LclmwTX4Zj5Bapqdq5Xtxgv8MySbP498EqEag+SjdlsTpD8tdOyLjDCz9iFlLWR5
v326fOwuXozMnbfCh6ECpkuMQoOePZNfspKka+t8rHYMjeOWjMc5/9yXscZ2zW4=
=XHoI
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: whole-words-only.patch
Type: text/x-patch
Size: 16991 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20150110/368c5975/attachment.bin>


More information about the poppler mailing list