[poppler] RFC: Expose whole-words search option in Qt frontends

[Albert Astals Cid]

Maybe you can add some tests to check_search.cpp?

Cheers,
  Albert

El Dissabte, 10 de gener de 2015, a les 23:26:01, Adam Reichold va escriure:
> Hello again,
> 
> Am 10.01.2015 um 22:25 schrieb Albert Astals Cid:
> > El Dissabte, 10 de gener de 2015, a les 17:51:48, Adam Reichold va
> > 
> > escriure:
> >> Hello,
> >> 
> >> Attach is a patch that would expose Poppler's whole-words search
> >> option within the Qt frontends.
> >> 
> >> While the implementation seems straight forward so far, I would
> >> like to request comments whether extending the "SearchMode"
> >> enumeration to flag definition is considered harmless. The proper
> >> way to do it seems to be the introduction of "QFlags<SearchMode>"
> >> which would however break compatibility and hence imply the need
> >> to have an additional overloads using a separate flag (and
> >> enumeration?) definition.
> > 
> > Looks good to me. The qt5/ side would need the documentation update
> > too, no?
> 
> patch with fixed Qt5 documentation and "\since" commands attached.
> 
> Best regards, Adam.
> 
> > Cheers, Albert
> > 
> >> Best regards, Adam.
> > 
> > _______________________________________________ poppler mailing
> > list poppler at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/poppler