[poppler] very trivial patch for NSS3 library

Oliver Sander oliver.sander at tu-dresden.de
Thu Dec 21 12:50:23 UTC 2017


Hi mpsuzuki,

> It would be possible to check libnss version, to exclude too old
> version. Yet I'm unfamiliar with cmake, so what I could propose
> would be a check by pkg-config. It would be considerable option?

that sounds overly complicated to me.  If your nss version is to be
supported then simply applying your patch is much easier.  But that
is not on me to decide.

Regards,
Oliver

> 
> Regards,
> mpsuzuki
> 
> 
> Oliver Sander wrote:
>> Hmm.  Doesn't that sound more like a bug in hasht.h?  In any case,
>> the file hasht.h on my machine (Debian testing) starts with
>> #include "prtypes.h".
>>
>> Best,
>> Oliver
>>
>> On 21.12.2017 08:56, suzuki toshiya wrote:
>>> Hi,
>>>
>>> For signature calculation, poppler can use Mozilla's NSS3 library
>>> optionally. I receive a compiler error against PRBool types, because
>>> it is used by hasht.h before including its definition in prtypes.h.
>>> Here is a trivial patch to include prtypes.h before hasht.h.
>>>
>>> Regards,
>>> mpsuzuki
>>>
>>>
>>>
>>> _______________________________________________
>>> poppler mailing list
>>> poppler at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/poppler
>>>
>>
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 5158 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://lists.freedesktop.org/archives/poppler/attachments/20171221/4ea366e5/attachment.bin>


More information about the poppler mailing list