[poppler] [SOLVED] Re: very trivial patch for NSS3 library

[suzuki toshiya]

Dear Oliver,

Thank you for giving the chance to revisit my proposal.
After checking cmake testing result, I found that
current cmake checks the version of nss3 by default.

If I install old nss (libnss-3.14.5 whose hasht.h does not
include prtypes.h by itself), cmake refuses it, like:

=======================================================
-- Found TIFF: /usr/lib/x86_64-linux-gnu/libtiff.so (found version "4.0.7")
-- Checking for module 'nss>=3.19'
--
-- Could NOT find NSS3 (missing:  NSS3_LIBRARIES NSS3_CFLAGS)
=======================================================

So, older nss3 was already not supported! Maybe
I had some dirty configuration during repeated pack
/unpack the building directories.

Now I understand I should not propose anything about
this :-) I apologize that you spent times for me.

Regards,
mpsuzuki



Oliver Sander wrote:
> Hi mpsuzuki,
> 
>> Oh, maybe too few words made you misunderstood. Just I wanted to
>> propose to set a minimum version of libnss3 to be supported by
>> poppler. Ignoring too old libnss would be acceptable solution,
>> because such old libnss was used when poppler has no signature
>> calculation. So, the change would be just a few lines in CMakeLists.txt.
>> Now I'm trying to find the repository of libnss3 to find the minimum
>> version which we don't have to include prtypes.h...
> 
> indeed, I misunderstood you.  That idea sounds fine to me -- not too
> complicated at all.  However, as I said, it is not me who can decide
> whether explicitly stopping support for old nss libraries is what
> poppler wants to do.
> 
> Regards,
> Oliver
> 
>> This idea is either too complicated?
>>
>> Regards,
>> mpsuzuki
>>
>>> If your nss version is to be
>>> supported then simply applying your patch is much easier.  But that
>>> is not on me to decide.
>>>
>>> Regards,
>>> Oliver
>>>
>>>> Regards,
>>>> mpsuzuki
>>>>
>>>>
>>>> Oliver Sander wrote:
>>>>> Hmm.  Doesn't that sound more like a bug in hasht.h?  In any case,
>>>>> the file hasht.h on my machine (Debian testing) starts with
>>>>> #include "prtypes.h".
>>>>>
>>>>> Best,
>>>>> Oliver
>>>>>
>>>>> On 21.12.2017 08:56, suzuki toshiya wrote:
>>>>>> Hi,
>>>>>>
>>>>>> For signature calculation, poppler can use Mozilla's NSS3 library
>>>>>> optionally. I receive a compiler error against PRBool types, because
>>>>>> it is used by hasht.h before including its definition in prtypes.h.
>>>>>> Here is a trivial patch to include prtypes.h before hasht.h.
>>>>>>
>>>>>> Regards,
>>>>>> mpsuzuki
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> poppler mailing list
>>>>>> poppler at lists.freedesktop.org
>>>>>> https://lists.freedesktop.org/mailman/listinfo/poppler
>>>>>>
>