[poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

Jeroen Ooms jeroen at berkeley.edu
Mon Feb 12 12:12:00 UTC 2018


On Sun, Feb 11, 2018 at 12:11 PM, Albert Astals Cid <aacid at kde.org> wrote:
> You're never assigning to tv_nsec in there but still use it in a comparison,
> that needs fixing.

You are right. I think we should compare modification time only by
seconds. The standard definition of 'struct stat' only specifies
st_ctime, so I don't think there is a portable way to get nanoseconds:
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/stat.h.html

Here is the new updated patch:
https://github.com/jeroen/poppler-mirror/commit/741ec4da67981935cafe6095adef966ea818fec5

Thank you


More information about the poppler mailing list