[poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

Ihar Filipau thephilips at gmail.com
Mon Feb 12 14:04:02 UTC 2018


On 2/12/18, Jeroen Ooms <jeroen at berkeley.edu> wrote:
> On Sun, Feb 11, 2018 at 12:11 PM, Albert Astals Cid <aacid at kde.org> wrote:
>> You're never assigning to tv_nsec in there but still use it in a
>> comparison,
>> that needs fixing.
>
> You are right. I think we should compare modification time only by
> seconds. The standard definition of 'struct stat' only specifies
> st_ctime, so I don't think there is a portable way to get nanoseconds:
> http://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/stat.h.html

That's an old version of POSIX. Check the newer version:

http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_stat.h.html

IOW, there is a standard portable way - since 2008, 10 years ago. It's
just Mac OS X hasn't updated its POSIX support after POSIX v6, from
2004.


More information about the poppler mailing list