[poppler] Fix building static libraries with cmake

Albert Astals Cid aacid at kde.org
Tue Jan 9 23:33:23 UTC 2018


El dimecres, 1 de novembre de 2017, a les 11:55:41 CET, Jeroen Ooms va 
escriure:
> Several projects use static builds of poppler-cpp to ship standalone
> pdf applications, but since the switch to cmake it is no longer
> possible to build static libs.
> 
> Setting -DBUILD_SHARED_LIBS=OFF in cmake only builds a static
> libpoppler.a, however libpoppler-cpp still gets built as a dynamic
> library (because SHARED is hardcoded in CMakeLists.txt).
> 
> It would be really great of cmake could build both the static and the
> shared libraries, like many other C/C++ libs do. The patch below
> implements this:
> 
>   Human readable view:
> https://github.com/tsdgeos/poppler_mirror/pull/2/files Patch file:
> https://github.com/tsdgeos/poppler_mirror/pull/2.patch
> 
> What can I do to get this patch reviewed?

So this patch doubles compilation time because everything is compiled twice?

I don't think i want that.

Cheers,
  Albert

> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/poppler




More information about the poppler mailing list