[poppler] Requires.private field missing in poppler.pc

suzuki toshiya mpsuzuki at hiroshima-u.ac.jp
Mon Mar 26 12:26:22 UTC 2018


Hi all,

Here is the updated patch to write extra dependencies
to pkg-config files if archive library is built.
https://github.com/mpsuzuki/poppler/compare/5e7aef...cmake-for-static

I attached a patch without .travis.yml.

In comparison with my last patch, my function definitions
are separated to cmake/modules/FindPkgCfgFromLdflags.cmake
(about 70 lines), but still 100 lines are added to
CMakeLists.txt. If it's still too large for poppler
maintainers, I would separate more.

=======================================================

my classifications are following.

building for win32
------------------
do nothing, same with before patch.

building shared library with newer pkg-config >= 0.18
------------------------------------------------------
extra dependencies for archive library are written to
Requires.private and Libs.private, but we cannot check
whether it is working, because we don't build archive
library in this config.

building shared library with older pkg-config < 0.18
-----------------------------------------------------
do nothing, same with before patch, because
older pkg-config does not support xxx.private variables.

building archive library
-------------------------
extra dependency for archive libraries are written to
Requires and Libs, xxx.private variables are not used.

=======================================================

on ubuntu and macos, linking of external program finishes
successfully.
https://travis-ci.org/mpsuzuki/poppler/builds/358343594

I want to test for Win32 (to add a condition, the
environment by free software is expected), so please
let me know the standard environment to confirm if
I break nothing.

Regards,
mpsuzuki

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-poppler-pc-static_20180326-2115.diff
Type: text/x-patch
Size: 10326 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/poppler/attachments/20180326/7cce1351/attachment.bin>


More information about the poppler mailing list