[poppler] [RFC] poppler_form_field_get_font_size is broken

Albert Astals Cid aacid at kde.org
Mon Mar 26 17:36:45 UTC 2018


So i was looking at Annot and realized we have a fontSize member that is 
initialized to 0 and just used to return in glib 
poppler_form_field_get_font_size

The attached patch removes the member variable and makes 
poppler_form_field_get_font_size return 0. This is obviously not the correct 
fix, but maybe it's better to commit this (maybe adding a TODO to the glib 
code) than having some code that does nothing (until someone can actually fix 
it properly?)

Cheers,
  Albert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: poppler_form_field_get_font_size.patch
Type: text/x-patch
Size: 2254 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/poppler/attachments/20180326/791f78a3/attachment-0001.bin>


More information about the poppler mailing list