[poppler] [RFC] poppler_form_field_get_font_size is broken

[Adam Reichold]

Hello,

Am 26.03.2018 um 19:36 schrieb Albert Astals Cid:
> So i was looking at Annot and realized we have a fontSize member that is 
> initialized to 0 and just used to return in glib 
> poppler_form_field_get_font_size
> 
> The attached patch removes the member variable and makes 
> poppler_form_field_get_font_size return 0. This is obviously not the correct 
> fix, but maybe it's better to commit this (maybe adding a TODO to the glib 
> code) than having some code that does nothing (until someone can actually fix 
> it properly?)

I think the change is reasonable and the TODO would help. Better to have
it explicitly broken than to follow a mirage of partial implementations.

Best regards, Adam.

> Cheers,
>   Albert
> 
> 
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/poppler
>