[poppler] Requires.private field missing in poppler.pc

[suzuki toshiya]

Albert Astals Cid wrote:
>> In comparison with my last patch, my function definitions
>> are separated to cmake/modules/FindPkgCfgFromLdflags.cmake
>> (about 70 lines), but still 100 lines are added to
>> CMakeLists.txt. If it's still too large for poppler
>> maintainers, I would separate more.
> 
> The patch seems a bit weird, I mean all the execute_process in 
> FindPkgCfgFromLdflags seems like it's a bit convoluted, have you tried asking 
> in the cmake mailing list?

Thank you for prompt review. Indeed, I have to accept that
most maintainers would be unwilling to include such long
patch just for static linking (and wondering why such is
needed). The convolution of the patch is coming from the
situation that I'm unfamiliar with the stability of the
handling of pkg-config in cmake (then I did something like a
reversal mapping from LDFLAGS/LIBS to corresponding pkg-
config module). OK, I will track the historical change
and if I can be sure as they are stable, I would try to
do same thing without reversal mapping method.

and if I could not be sure the stability,

> I guess we're not the first ones with this problem?

I would follow to this suggestion.

many thanks again for spending your time!

Regards,
mpsuzuki


Albert Astals Cid wrote:
> El dilluns, 26 de març de 2018, a les 14:26:22 CEST, suzuki toshiya va 
> escriure:
>> Hi all,
>>
>> Here is the updated patch to write extra dependencies
>> to pkg-config files if archive library is built.
>> https://github.com/mpsuzuki/poppler/compare/5e7aef...cmake-for-static
>>
>> I attached a patch without .travis.yml.
>>
>> In comparison with my last patch, my function definitions
>> are separated to cmake/modules/FindPkgCfgFromLdflags.cmake
>> (about 70 lines), but still 100 lines are added to
>> CMakeLists.txt. If it's still too large for poppler
>> maintainers, I would separate more.
> 
> The patch seems a bit weird, I mean all the execute_process in 
> FindPkgCfgFromLdflags seems like it's a bit convoluted, have you tried asking 
> in the cmake mailing list?
> 
> I guess we're not the first ones with this problem?
> 
> Cheers,
>   Albert
> 
> 
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/poppler