[poppler] 2 commits - fofi/FoFiType1C.cc goo/GooString.h poppler/Form.cc

[Albert Astals Cid]

El dimecres, 10 d’abril de 2019, a les 20:21:07 CEST, Brüns, Stefan va escriure:
> On Mittwoch, 10. April 2019 17:14:26 CEST GitLab Mirror wrote:
> 
> >  //========================================================================
> > 
> > @@ -64,8 +65,8 @@ char* pdfDocEncodingToUTF16 (const GooString* orig, int*
> > length) char *result = new char[(*length)];
> >    const char *cstring = orig->c_str();
> >    //unicode marker
> > -  result[0] = (char)0xfe;
> > -  result[1] = (char)0xff;
> > +  result[0] = '\xfe';
> > +  result[1] = '\xff';
> 
> This will cause issues on all architectures where char is unsigned, e.g. ARM 
> (32 and 64bit), PPC.
> 
> Please use an explicit "unsigned char" whenever you will assign values >= 0x80 
> to it.

Is this an actual regression in this patch?

Cheers,
  Albert

> 
> Regards,
> 
> Stefan
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/poppler
>