[poppler] poppler/PDFDoc.cc

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jan 2 14:23:04 UTC 2019


 poppler/PDFDoc.cc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9fd5ec0e6e5f763b190f2a55ceb5427cfe851d5f
Author: Albert Astals Cid <aacid at kde.org>
Date:   Mon Dec 31 11:47:57 2018 +0100

    PDFDoc::setup: Fix return value
    
    At that point xref can have gone wrong since extractPDFSubtype() can
    have caused a reconstruct that broke stuff so instead of unconditionally
    returning true, return xref->isOk()
    
    Fixes #706

diff --git a/poppler/PDFDoc.cc b/poppler/PDFDoc.cc
index 351bd2ea..9213f567 100644
--- a/poppler/PDFDoc.cc
+++ b/poppler/PDFDoc.cc
@@ -311,7 +311,7 @@ bool PDFDoc::setup(const GooString *ownerPassword, const GooString *userPassword
   extractPDFSubtype();
 
   // done
-  return true;
+  return xref->isOk();
 }
 
 PDFDoc::~PDFDoc() {


More information about the poppler mailing list