[poppler] poppler/PDFDoc.cc

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jan 3 18:49:21 UTC 2019

 poppler/PDFDoc.cc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1e99a1eeb3a144facf45165df9f457796c045daa
Author: Albert Astals Cid <aacid at kde.org>
Date:   Thu Jan 3 19:47:10 2019 +0100

    Revert 9fd5ec0e6e5f763b190f2a55ceb5427cfe851d5f
    It was causing regressions for some half-broken files
    Even if xref::constructXRef is returning false, that only means "i
    din't find a new xref root", but constructXRef is also quite stubborn in
    which it basically parses the whole file and stores the positions of all
    the objects it finds, so for some half broken pdf files this is good
    enough and we will be able to render those files just fine

diff --git a/poppler/PDFDoc.cc b/poppler/PDFDoc.cc
index 1fa740a4..93fa4464 100644
--- a/poppler/PDFDoc.cc
+++ b/poppler/PDFDoc.cc
@@ -311,7 +311,7 @@ bool PDFDoc::setup(const GooString *ownerPassword, const GooString *userPassword
   // done
-  return xref->isOk();
+  return true;
 PDFDoc::~PDFDoc() {

More information about the poppler mailing list