[Portland-bugs] [Bug 56092] New: XFCE .desktop file created for browser selection is broken

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=56092

          Priority: medium
            Bug ID: 56092
          Assignee: portland-bugs at lists.freedesktop.org
           Summary: XFCE .desktop file created for browser selection is
                    broken
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: random832 at fastmail.us
          Hardware: All
            Status: NEW
           Version: 1.1.0 rc1
         Component: xdg-utils
           Product: Portland

XFCE requires a special format of .desktop file for what it calls "helpers".
This requirement is handled by the check_xfce_desktop_file function in
xdg-settings. The function "converts" an existing application .desktop file by
removing the Type line and adding the so-called custom tweaks it requires.

This breaks when the application .desktop file has multiple sections (for
example, the chromium-browser.desktop that is present on Ubuntu).

I propose that instead of "converting" an existing application .desktop file,
when an existing XFCE helper .desktop file is not found it should create a
minimal one with only the necessary content. This would match more closely to
what what is done by XFCE's own preferred applications GUI when you browse for
a path to select a browser. It should be noted that the GUI always creates
"custom-WebBrowser.desktop" rather than [application].desktop, but this
behavior does not appear to be important and I am not sure yet if it is
desirable (I need to do more testing with how Chromium detects that it is not
the default browser to be sure).

I have already started working on a new version of this function, but have not
finished testing yet. I will attach it later this week.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/portland-bugs/attachments/20121017/ae03573c/attachment.html>