[Portland] Repository needed

[Lubos Lunak]

On Thursday 02 March 2006 14:18, Kevin Krammer wrote:
> > > Index: configure.ac
> > > -AC_CONFIG_HEADER(config.h)
> > > +AM_CONFIG_HEADER(config.h)
> >
> >  I just copied most of that from somewhere, feel free to fix in CVS.
>
> Haven't asked for CVS commit access yet, if the patch works for you as well
> better commit it yourself

 Ok, done.

> Btw, I think the arguments that are files (attachments, LocalFile
> parameters, etc) have to be specified more clearly, i.e. are they supposed
> to be file:// URIs or just paths, if just paths, are relative paths allowed
> and if yes who is responsible for generating the absolute path.

 That's why others should comment on the stuff :). Some of that is already 
kind of specified (filename means just a filename, i.e. path). And paths have 
to be absolute because the daemon's and app's cwd don't necessarily match.
I think there should be Conventions section in API.txt that'd sum up things 
like this instead of repeating all the time that everything is UTF8 etc. 
Something like:

"
Conventions:
========

All strings, filenames, urls, etc. are UTF8-encoded, unless specified 
otherwise.

All filenames and paths must be absolute.
"

 Something more? If we later go past the just-localhost scope then filenames 
will have to be file:/ URLs that include the hostname, but I wouldn't bother 
with that for now.

> If I have enough time this evening I'll try to create patches for the
> addressbook functions.

(Disclaimer: I'm somewhat clueless about addressbooks. I don't even use it as 
a user.)
 IMHO it'd make more sense to first decide on the API calls themselves (i.e. 
for API.txt) before actually starting implementing. The Wiki description for 
querying the addressbook is pretty vague. What queries do apps actually need? 
What info do they want to get back?

> Any hint where I had those memory leaks in my original code?

 You didn't free the char* strings you get from dapi_readCommandFoo() - as the 
API is still pretty experimental the docs are somewhat ... uhm ... sparse.

-- 
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o.  e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27  tel: +420 2 9654 2373
190 00 Praha 9   fax: +420 2 9654 2374
Czech Republic   http://www.suse.cz/