[pulseaudio-tickets] [Bug 43503] Xen paravirtualized driver frontend module

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43503

--- Comment #6 from Tanu Kaskinen <tanuk at iki.fi> 2011-12-07 08:53:37 PST ---
(In reply to comment #5)
> Tanu, what do you think the best plan is here?
> 
> 1) Have udev-detect notice that it is running as a guest and just unload itself
> (cleanly). and have a totally separate module module-xenpv-detect configured in
> our default.pa file which is similarly designed to exit gracefully if it does
> not detect a Xen guest?
> 
> 2) module-udev-detect itself actually loads module-xenpv-detect and unloads
> itself when it detects Xen guest mode.
> 
> 
> While the latter is less "pure" from a configuration aspect, it's nicer to not
> try and load xen stuff when not needed if the support is compiled in (and doing
> .nofail blocks in the default.pa is a bit crappy to work around "optional
> modules" as it's arguably not an optional module when you are running under
> Xen).

I'd argue that the Xen modules still are optional even in Xen guest
environment. You can use Pulseaudio also through network, for example. Why is
.nofail needed anyway? Isn't .ifexists good enough?

So, my preference would be to have both module-udev-detect and
module-xenpv-detect in the default configuration, guarded by .ifexists, and if
the modules detect that they are useless they unload themselves (udev is
useless if it detects that it's running in a Xen guest, and xenpv is useless in
the opposite case). In the usual case module-xenpv-detect won't be installed,
so Pulseaudio won't try to load it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.