[pulseaudio-tickets] [Bug 43503] Xen paravirtualized driver frontend module

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=43503

--- Comment #7 from Maarten Bosmans <mkbosmans at gmail.com> 2011-12-26 03:22:43 PST ---
Good patch, it seems like you addressed all my earlier comments.

Some points:


Why is the patch adding src/module-xenpv-sink.c? This file should be in
src/modules/.


What's up with this weird hunk?

diff --git a/src/modules/module-xenpv-sink.c b/src/modules/module-xenpv-sink.c
new file mode 120000
index 0000000..6e87ea3
--- /dev/null
+++ b/src/modules/module-xenpv-sink.c
@@ -0,0 +1 @@
+/xen-audio/frontend/module-xenpv-sink.c
\ No newline at end of file


And finally, I don't get the point of the xen_gnt.h file. Is it something
specific to this sink, or is it a general Xen header? In the last case it
should not be added to the pulseaudio source. At any rate, a comment at the top
of that file summarising its purpose, origin and license would be most welcome.

If the header really needs to be in our tree, I'd prefer you make a separate
src/modules/xen directory for both xen_gnt.h and module-xenpv-sink.c, to keep
src/modules clean, just like e.g. is done for alsa and rtp headers/source
files.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are the assignee for the bug.