[pulseaudio-tickets] [Bug 72414] New: bluetooth/module-bluetooth-policy.c:150: possible bad if test ?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=72414

          Priority: medium
            Bug ID: 72414
                CC: lennart at poettering.net
          Assignee: pulseaudio-bugs at lists.freedesktop.org
           Summary: bluetooth/module-bluetooth-policy.c:150: possible bad
                    if test ?
        QA Contact: pulseaudio-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: dcb314 at hotmail.com
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: modules
           Product: PulseAudio

I just ran static analyser "cppcheck" over the
source code of pulseaudio-4.0-266-gf81e3. It said
many things, including

[modules/bluetooth/module-bluetooth-policy.c:150] ->
[modules/bluetooth/module-bluetooth-policy.c:150]: (style) Same expression on
both sides of '>'.

Source code is

        if (result == NULL ||
            (profile->available == PA_AVAILABLE_YES && result->available ==
PA_AVAILABLE_UNKNOWN) ||
            (profile->available == result->available && profile->priority >
profile->priority))

Suggest code rework.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20131206/188700d1/attachment.html>