[pulseaudio-tickets] [Bug 60405] New: Review the usage of pa_memblockq_push()

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=60405

          Priority: medium
            Bug ID: 60405
                CC: lennart at poettering.net
          Assignee: pulseaudio-bugs at lists.freedesktop.org
           Summary: Review the usage of pa_memblockq_push()
        QA Contact: pulseaudio-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: tanuk at iki.fi
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: misc
           Product: PulseAudio

In many places the return value of pa_memblockq_push() and
pa_memblockq_push_align() isn't checked (a negative return value indicates that
the queue is full). In some places the function can't fail (an assertion could
be added for these), and in some places we're missing proper error handling in
case the queue gets full.

There is already a patch[1] that adds some assertions. I don't apply it now,
because it's old and might need updating for the current codebase, and it's
incomplete anyway (many FIXME items).

Another issue is that pa_memblock_push_align() is often used where
pa_memblockq_push() could be used.

[1] http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/13312

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20130207/4794144e/attachment.html>