[pulseaudio-tickets] [Bug 55280] tunnel modules cannot figure out adress/auth automatically

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=55280

--- Comment #7 from Tanu Kaskinen <tanuk at iki.fi> ---
The tunnel module should get rewritten so that it uses libpulse, and this bug
should get resolved as a side effect. There is no 100% guarantee that the
rewrite project will finish, so if you want this patch applied anyway, I'm not
against that. Some review comments follow.

In pa__init(), the server variable is never freed, even if it should be:

#ifdef HAVE_X11
    if ((server == NULL) && (xcb != NULL)) {
        char t[1024];
        if (pa_x11_get_prop(xcb, 0, "PULSE_SERVER", t, sizeof(t)))
            server = pa_xstrdup(t);
    }
#endif

It doesn't seem like a good idea to connect to a local server by default. If
the user loads module-tunnel-sink without any arguments, I think it should
fail, because tunneling to a local daemon doesn't usually make sense. I think
it would be better if connecting to a local server would require an explicit
indication that the user really wants to do that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20130714/5fa29735/attachment-0001.html>