[pulseaudio-tickets] [Bug 76529] New: Mix of translated and untranslated message

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=76529

          Priority: medium
            Bug ID: 76529
                CC: lennart at poettering.net
          Assignee: pulseaudio-bugs at lists.freedesktop.org
           Summary: Mix of translated and untranslated message
        QA Contact: pulseaudio-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: goeran at uddeborg.se
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: tools
           Product: PulseAudio

Note: I originally reported this in the tracking system at
http://pulseaudio.org/ticket.  But it does no longer seem active, and the bug
is still there, so I repeat the report here.

In src/utils/pacat.c, in the function stream_state_callback, there is this
code:

pa_log(_("Connected to device %s (%u, %ssuspended)."),
        pa_stream_get_device_name(s),
        pa_stream_get_device_index(s),
        pa_stream_is_suspended(s) ? "" : "not ");

The word "not" is not available for translation here.  And building messages
from pieces in this way often breaks translations.  I'm sure there are some
language where the word "suspended" should have different forms depending on
whether it is negated or not.

I would suggest to make two complete messages instead, and select the entire
message based on the return value of pa_stream_is_suspended().

An addition/alternative was suggested by "mkbosmans" in my original report:

If someone is going over the source code and review for translation
difficulties, then please also look at pa_yes_no in pulsecore/core-util.c.
Those little two strings should be translated also.

Perhaps that's even a possible solution here:

pa_log(_("Connected to device %s (%u, suspended: %s)."),
        pa_stream_get_device_name(s),
        pa_stream_get_device_index(s),
        pa_yes_no(pa_stream_is_suspended(s));

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20140323/3ea8453c/attachment.html>