[pulseaudio-tickets] [Bug 78701] Implement systemd socket activation in pulseaudio

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=78701

Colin Guthrie <colin at mageia.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin at mageia.org

--- Comment #10 from Colin Guthrie <colin at mageia.org> ---
Ooops, I should have read this bug before hacking on the same things!

I posted a separate patch to the ML to do this too. Mine doesn't do the IP
activation yet however (I was lazy!), but as with this patch it's relatively
trivial to add.

I opted for not creating a new function to adopt the socket and just checked
when creating a new socket server if we happen to have a passed FD that matches
via the sd_is_socket_*() function and avoid the bind+listen step. That seems
cleaner to me that a separate adopt function, but perhaps that's just taste.

Some things slightly different in my patch:

1. I still set filename for unix sockets such that the address is properly
calculated and thus exported in e.g. module-x11-publish. I use a separate
variable inside the socket server to track whether it's been activated and
avoid the unlink when closing.

2. I added an install-data-hook to automatically ship a static symlink to start
the socket. This means that it users do not need to do any manual configuration

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20141019/db851b24/attachment.html>