[pulseaudio-tickets] [Bug 93855] Module restore restores volume and mute settings from wrong sink input

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=93855

--- Comment #3 from Leonard den Ottolander <leonard-rh-bugzilla at den.ottolander.nl> ---
I think you misunderstand what I say.

To restore the stream a /unique/ identifier needs to be used. The currently
used function function pa_proplist_get_stream_group() does not do this as it
returns a non unique application name.

Using the pid of the original stream is perfectly fine. The module is just
looking for a unique string and the pid of the (old) stream is such a unique
name. The string is not used to look for the process with that particular pid,
it is just a way to ensure that the string that identifies the stream is
unique.

The patches in my first example actually fix the module restore stream, but as
I explain in comment #2 reusing the function pa_proplist_get_stream_group() is
a  bad idea as it interferes with module-filter-apply.c. This is why I split
out the function pa_proplist_get_stream_id() in the attached patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20160125/d461f43d/attachment.html>