[pulseaudio-discuss] [PATCH 1/4] stream-restore: add volume_is_absolute bool in client side

Lennart Poettering lennart at poettering.net
Sat Jun 6 15:00:41 PDT 2009


On Sat, 06.06.09 16:44, Felipe Contreras (felipe.contreras at gmail.com) wrote:

> 
> On Sat, Jun 6, 2009 at 4:26 PM, Lennart
> Poettering<lennart at poettering.net> wrote:
> > On Sat, 06.06.09 15:59, Felipe Contreras (felipe.contreras at gmail.com) wrote:
> >
> >> >> #if HAVE_STDBOOL_H
> >> >> #include <stdbool.h>
> >> >> #else
> >> >> typedef unsigned char bool
> >> >> #endif
> >> >>
> >> >
> >> > This is in public headers. That would mean you have to ensure that the
> >> > library and the client side are compiled both with the same config.
> >> > Which means practically requiring it to be C99, and thus the if is not
> >> > even necessary.
> >>
> >> Public headers?
> >
> > What you were suggesting needs to be placed in public
> > headers. i.e. the HAVE_STDBOOL_H would need to be defined properly for
> > all builds, and the same for the library and the clients build.
> 
> Is pa_bool_t in the public headers?

No. And I tried to explain why not.

Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/           GnuPG 0x1A015CC4



More information about the pulseaudio-discuss mailing list