[pulseaudio-discuss] [PATCH] JACK: Add module-jackdbus-detect

[David Henningsson]

Over the past few days I've been making a new PulseAudio module that 
detects the presence of JACK server, and adds a sources and a sink when 
JACK is started.

Here are the notes:

* This version uses JACK's dbus interface to detect server being started 
or stopped, i e /usr/bin/jackdbus instead of /usr/bin/jackd.
If you use qjackctl to control the server, make sure that you check the 
checkbox "Enable D-Bus interface" under Setup -> Misc.

* It is deliberately named module-jackdbus-detect instead of 
module-jack-detect, both to emphasize the above, and to avoid name 
clashes with an imaginary (?) future module detecting whether headphones 
are plugged in or not.

* The patch is against stable-queue.

* It is probably ready for merging into the next version of PA. I'm 
saying probably, since during testing yesterday, I sometimes got 
segfaults. However, I believe these are related to something happening 
inside libjack when the server shuts down; since I can trigger the same 
segfaults even without my new module involved. That said; it takes fewer 
strokes with the module enabled, as you can just press "start" and 
"stop" in qjackctl until it happens...

* A question is about the default; patch 2 here adds it to default.pa. 
Should "connect" default to true or false in such a scenario? I think it 
depends on whether we're aiming for just showing the user the 
possibility (connect=false), or if we're aiming for a just-works 
experience (connect=true), which might upset a few people who don't want 
it to work that way...I've gone with connect=true as the default to 
mimic the behaviour of module-jack-sink and module-jack-source.

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-JACK-Add-module-jackdbus-detect.patch
Type: text/x-patch
Size: 10840 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20101203/ec38fdcf/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-JACK-Load-module-jackdbus-detect-in-default.pa.patch
Type: text/x-patch
Size: 938 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20101203/ec38fdcf/attachment-0001.bin>