[pulseaudio-discuss] [PATCH] Fix bad returned format in sound file utils

Colin Guthrie gmane at colin.guthr.ie
Sat Dec 18 03:51:54 PST 2010

'Twas brillig, and Becker, VincentX at 15/12/10 09:11 did gyre and gimble:
> This patch fixes an issue when using pacat with option --file-format.
> As the format number returned by pa_sndfile_format_from_string() was
> wrong, it failed to open later audio file especially with the record
> option (e.g. : pacat -r --file-format=flac file_to_record). With the
> fix, it creates the sound file header of the desired format in the
> uncompressed audio file.

Thanks for this Vincent.

I thought it a little odd at first as "fi.format = i;" is run just a few
lines above, but I see that libsndfile kind of abuses the fi.format when
calling that function and uses it as an index and overwrites it with the
real format on return.

Applied now in my tree.




Colin Guthrie

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

More information about the pulseaudio-discuss mailing list