[pulseaudio-discuss] [PATCH 2/2] Use SOUND_CLASS instead of SOUND_FORM_FACTOR for newer udev

[Lennart Poettering]

On Mon, 04.01.10 21:59, Daniel Chen (seven.steps at gmail.com) wrote:

> From 109b0d2016e89785d713f0a7666e530b2966edd8 Mon Sep 17 00:00:00 2001
> From: Daniel T Chen <crimsun at ubuntu.com>
> Date: Mon, 4 Jan 2010 21:53:36 -0500
> Subject: [PATCH 2/2] Use SOUND_CLASS instead of SOUND_FORM_FACTOR for newer udev
> 
> Newer udev versions enumerate the SOUND_CLASS property instead of
> SOUND_FORM_FACTOR, so use the former.

The patch is good, the commit text not though. Both properties exist
in modern udev. However SOUND_CLASS distuingishes in which way the
alsa card works: i.e. is it for generating audio you can listen to, or
a modem stream for a POTS line, and SOUND_FORM_FACTOR tells us in what
"boxing" the device comes, i.e. external speakers, internal cards,
headphones, yadda yadda.

Of course since this code is used to detect modems we do indeedneed to check
SOUND_CLASS not SOUND_FORM_FACTOR. I fixed the commit text now and
merged it.

Thank you!

Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/           GnuPG 0x1A015CC4