[pulseaudio-discuss] About volume ramping

[Lennart Poettering]

On Wed, 30.12.09 16:20, huan zheng (huan.zheng.zbt at gmail.com) wrote:

> Hi,
Heya!

> I found that volume ramping is inside PA now.
> there's a minor fix here, it is a bug i found after the patch is submitted:
> 
> line 1781 of sink-input.c :
> if ((i->thread_info.ramp_info.envelope_dying - nbytes) <= 0) {
> need to be changed to
> if ((i->thread_info.ramp_info.envelope_dying - (ssize_t) nbytes) <= 0) {
> 
> otherwise this argument will never be negative since nbytes is of type
> size_t which is unsigned.
> Please change it when you have time, sorry if bring any inconvenience. :)

Thanks for the hint.

I have fixed that now. Note that I merged that but have not really
tested yet and my plan is to extend this to proper multichannel
ramping before the actual release.

(BTW: proper patches greatly preferred)

Lennart

-- 
Lennart Poettering                        Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/           GnuPG 0x1A015CC4