[pulseaudio-discuss] [PATCH] Fix crash on jack server shutdown

[David Henningsson]

On sink unlinking, existing sink inputs are moved, which in turn calls
a get latency callback, which references the jack client. Therefore,
make sure the sink is unlinked before the client is closed. Failure to
do so might lead to SIGSEGV.

This patch simply moves the call to pa_sink_unlink above
jack_client_close, which fixes the problem.

Steps to reproduce:

1. Disable autospawn and kill PA
2. Start jack server
3. Start PA
4. Load module module-jack-sink
5. Start a stream (e g Rythmbox) and run it through the jack sink.
6. Shutdown the jack server. Now PA crashes with SIGSEGV.

@Daniel T Chen: let me know if you want this patch as a merge proposal as
well. There is no bug in Launchpad AFAIK.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-crash-on-jack-server-shutdown.patch
Type: text/x-patch
Size: 1184 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20100314/c4dc428f/attachment.bin>