[pulseaudio-discuss] RFC: Adding "headset" form factor sinks to the "phone" intended role

[Daniel Chen]

On Mon, Oct 11, 2010 at 9:58 AM, Colin Guthrie <gmane at colin.guthr.ie> wrote:
> diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c
> index ff4cc17..3224467 100644
> --- a/src/pulsecore/sink.c
> +++ b/src/pulsecore/sink.c
> @@ -2708,7 +2708,8 @@ pa_bool_t
> pa_device_init_intended_roles(pa_proplist *p) {
>         return TRUE;
>
>     if ((s = pa_proplist_gets(p, PA_PROP_DEVICE_FORM_FACTOR)))
> -        if (pa_streq(s, "handset") || pa_streq(s, "hands-free")) {
> +        if (pa_streq(s, "handset") || pa_streq(s, "hands-free")
> +            || pa_streq(s, "headset")) {
>             pa_proplist_sets(p, PA_PROP_DEVICE_INTENDED_ROLES, "phone");
>             return TRUE;
>         }

Looks fine in principle.  Have you seen any mislabeled headsets?

Best,
-Dan