[pulseaudio-discuss] RFC: Adding "headset" form factor sinks to the "phone" intended role

[Colin Guthrie]

'Twas brillig, and Daniel Chen at 11/10/10 16:47 did gyre and gimble:
> On Mon, Oct 11, 2010 at 9:58 AM, Colin Guthrie <gmane at colin.guthr.ie> wrote:
>> diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c
>> index ff4cc17..3224467 100644
>> --- a/src/pulsecore/sink.c
>> +++ b/src/pulsecore/sink.c
>> @@ -2708,7 +2708,8 @@ pa_bool_t
>> pa_device_init_intended_roles(pa_proplist *p) {
>>         return TRUE;
>>
>>     if ((s = pa_proplist_gets(p, PA_PROP_DEVICE_FORM_FACTOR)))
>> -        if (pa_streq(s, "handset") || pa_streq(s, "hands-free")) {
>> +        if (pa_streq(s, "handset") || pa_streq(s, "hands-free")
>> +            || pa_streq(s, "headset")) {
>>             pa_proplist_sets(p, PA_PROP_DEVICE_INTENDED_ROLES, "phone");
>>             return TRUE;
>>         }
> 
> Looks fine in principle.  Have you seen any mislabeled headsets?

Not personally, but then I don't really have much in the way of h/w,
which is the main reason I'm asking for feedback :D

I've got one headset somewhere... lets see what it says...

	device.serial = "0d8c_C-Media_USB_Headphone_Set"
	device.form_factor = "headphone"

Well that's a bad example... even the source part of it says
"headphone"... I guess I need to fix that up somehow, but it doesn't
actually help here one way or the other!

Col


-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]