[pulseaudio-discuss] [PATCH] SSE/MMX/ARM: Fix high frequency noise with unusual number of channels
david.henningsson at canonical.com
Wed Oct 13 02:18:44 PDT 2010
On 2010-10-13 09:53, Colin Guthrie wrote:
> 'Twas brillig, and David Henningsson at 13/10/10 07:27 did gyre and gimble:
>> We have got three confirmations that the patch is working in the bug
>> below, so I believe it can be safely applied to both master and
> Would you mind respinning the patch with a couple more inline comments?
> I'm a little concerned about the lines such as "channels = channels == 3
> ? 6 : PA_MAX(....)"
> It will be a bit disconcerting to read this in code without really
> reading the relevant commit message, so I think a small hint towards why
> this is done would be good here.
Thanks for reviewing the patch, I agree that a little clearer comment
wouldn't hurt, so here's a revised version.
David Henningsson, Canonical Ltd.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4601 bytes
Desc: not available
More information about the pulseaudio-discuss