[pulseaudio-discuss] [PATCH] SSE/MMX/ARM: Fix high frequency noise with unusual number of channels

[Colin Guthrie]

'Twas brillig, and David Henningsson at 13/10/10 10:18 did gyre and gimble:
> On 2010-10-13 09:53, Colin Guthrie wrote:
>> 'Twas brillig, and David Henningsson at 13/10/10 07:27 did gyre and
>> gimble:
>>> We have got three confirmations that the patch is working in the bug
>>> below, so I believe it can be safely applied to both master and
>>> stable-queue.
>>
>> Great!
>>
>> Would you mind respinning the patch with a couple more inline comments?
>> I'm a little concerned about the lines such as "channels = channels == 3
>> ? 6 : PA_MAX(....)"
>>
>> It will be a bit disconcerting to read this in code without really
>> reading the relevant commit message, so I think a small hint towards why
>> this is done would be good here.
> 
> Thanks for reviewing the patch, I agree that a little clearer comment
> wouldn't hurt, so here's a revised version.

Great, thanks. Pushed now to master and s-q.

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]