[pulseaudio-discuss] [PATCH 1/8] devices: Set certain sink/source flags automatically.

Tanu Kaskinen tanuk at iki.fi
Wed Jul 13 09:00:11 PDT 2011


On Wed, 2011-07-13 at 15:37 +0100, Colin Guthrie wrote:
> 'Twas brillig, and Tanu Kaskinen at 13/07/11 14:29 did gyre and gimble:
> > Another thing came to my mind: what about having assertions for checking
> > that none of PA_SINK_HW_VOLUME_CTRL, PA_SINK_HW_MUTE_CTRL or
> > PA_SINK_SYNC_VOLUME are set? If the sink implementations can't control
> > the flags anyway, wouldn't it make sense to prevent them from trying?
> 
> Not really sure where you suggest such a check goes.
> 
> Do you mean e.g. before the initial call to
> pa_sink_set_flags_from_callbacks() inside pa_sink_put()?

Yes.

-- 
Tanu



More information about the pulseaudio-discuss mailing list