[pulseaudio-discuss] [PATCH] Remove unnecessary #includes

Colin Guthrie gmane at colin.guthr.ie
Wed Jun 22 15:49:51 PDT 2011

'Twas brillig, and Maarten Bosmans at 22/06/11 17:24 did gyre and gimble:
> 2011/6/22 Colin Guthrie <gmane at colin.guthr.ie>:
>> 'Twas brillig, and Maarten Bosmans at 22/06/11 15:56 did gyre and gimble:
>>> These are all unnecessary.
>>>  227 files changed, 76 insertions(+), 472 deletions(-)
>> /me wonders what the compile time difference is.... :)
> I wondered about that too, but it turned out to be disappointingly
> little (2s or so).


>> I did wonder how many of the includes are unneeded recently after doing
>> a bit of copy+paste hacking :) Nice to see you do the actual hard work!
> yup, the copy-pasting was very visible at some places. Of course I'm
> not claiming that every include is where it should be now, but the
> current patch is already way past sensible from a diminishing returns
> point of view.
>> I'll do a distcheck etc. and then push it out if all is well. I guess it
>> is fine on win32 too? Maybe Daniel can check on OSX also....?
> yup win32 is fine. And from now on I'll do my pre-submit distcheck
> with things like fftw and jack enabled too, that stuff gets sanity
> checked also before I send it to the list.

Nice :)

Pushed this one now.

Many thanks as always!



Colin Guthrie

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]

More information about the pulseaudio-discuss mailing list