[pulseaudio-discuss] [PATCH] Several fixes to Pulseaudio's Vala bindings

Colin Guthrie gmane at colin.guthr.ie
Thu Mar 24 15:51:41 PDT 2011


'Twas brillig, and Alexander Kurtz at 24/03/11 21:06 did gyre and gimble:
> Hi,
> 
> I have attached a patch with several small fixes to PA's Vala bindings:
> Let me explain my changes:
> 
>  1. PA uses Vala's ``Posix'' package (see line 23 of libpulse.vapi). 
>     These dependencies have to be declared in the *.deps file. 
> 
>  2. Fix obvious C&P error. 
> 
>  3. Rename the parameter to match the C function. This simplifies 
>     understanding what this parameter means. 
> 
>  4. According to the official documentation[1] the ``dev'' parameter 
>     may be NULL as this is the default. Change the method definition 
>     accordingly.
> 
> If you don't have any objections, please merge this patch into master.
> 
> Best regards
> 
> Alexander Kurtz

Thanks for the fixes :)

I've pushed this along with a tweak to the Makefile.am to install the
.deps file.

http://git.0pointer.de/?p=pulseaudio.git;a=commitdiff;h=705cf4d3164befffeb927e05d9f0f4402e9f80c4

Cheers

Col

-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]




More information about the pulseaudio-discuss mailing list