[pulseaudio-discuss] Current problems with git master

[Colin Guthrie]

'Twas brillig, and Colin Guthrie at 28/02/11 20:26 did gyre and gimble:
> 2. Startup is no longer atomic:
> 
> With PA not running and autospawn disabled:
>  [colin at jimmy ~]$ start-pulseaudio-x11
>  Connection failure: Connection refused
>  pa_context_connect() failed: Connection refused
> 
> PA does actually start but it's the pactl load-module's that cause this
> connection refused error. This means that pulseaudio --start returns
> before the daemon is ready for connections. This may also be something
> that is affecting the stable-queue (as I have heard of some startup
> races but never been able to reproduce).

OK, I've found when this problem was introduced and it was waaaaay back in:

commit 8e94f653489a0b3d549e61840a5cec711d466ab7
Author: Lennart Poettering <lennart at poettering.net>
Date:   Sat Oct 31 02:43:47 2009 +0100

    daemon: make sure pa has its own session and process group, but is
not its leader so that we cannot acquire a tty ever


which I think I've fixed in:

commit d47a33775b55877b9df42add3346779bba077299
Author: Colin Guthrie <cguthrie at mandriva.org>
Date:   Thu Mar 24 21:27:55 2011 +0000

    daemon: Fix regression with --start introduced with the double fork
in 8e94f653

    The previous commit intoduced a double fork which caused a more or
less immediate
    successful return prior to the hard work of actually starting a daemon.

    This patch simply used pipe() to only signal our father when the
daemon really
    has finished starting.


If someone could double check, I'd appreciate it (seeing as I'd rather
any bugs in my commit last less than a year and a half!!)


Col







-- 

Colin Guthrie
gmane(at)colin.guthr.ie
http://colin.guthr.ie/

Day Job:
  Tribalogic Limited [http://www.tribalogic.net/]
Open Source:
  Mageia Contributor [http://www.mageia.org/]
  PulseAudio Hacker [http://www.pulseaudio.org/]
  Trac Hacker [http://trac.edgewall.org/]