[pulseaudio-discuss] [PATCH 2/3] resampler: Rename buf3 and buf4 to buf4 and buf5.

David Henningsson david.henningsson at canonical.com
Mon Apr 23 03:38:01 PDT 2012

On 04/22/2012 08:28 PM, Tanu Kaskinen wrote:
> Input leftover handling is going to use buf3.

Am I the only one that eeeks over the subject of this patch? :-)

I guess this is not your fault originally, but if you're renaming them 
anyway, why don't give the buffers slightly more reasonable names that 
tells a little bit more on what the difference is between the buffers?

Otherwise, it seems reasonable to keep the memblock around until the 
next resampler run. I hope you'll find a way to really verify that it 
works well - the arithmetic seems a little complex :-)

David Henningsson, Canonical Ltd.

More information about the pulseaudio-discuss mailing list