[pulseaudio-discuss] [PATCH 2/3] resampler: Rename buf3 and buf4 to buf4 and buf5.

Tanu Kaskinen tanuk at iki.fi
Mon Apr 23 09:37:25 PDT 2012


On Mon, 2012-04-23 at 12:38 +0200, David Henningsson wrote:
> On 04/22/2012 08:28 PM, Tanu Kaskinen wrote:
> > Input leftover handling is going to use buf3.
> 
> Am I the only one that eeeks over the subject of this patch? :-)
> 
> I guess this is not your fault originally, but if you're renaming them 
> anyway, why don't give the buffers slightly more reasonable names that 
> tells a little bit more on what the difference is between the buffers?

Because it requires effort to come up with good names? You're of course
right. I'll also fix a couple of bugs that I found last night while
waiting to fall asleep (without looking at the code, which was sort of
interesting).

-- 
Tanu



More information about the pulseaudio-discuss mailing list