[pulseaudio-discuss] [PATCH PA1.1 1/2] alsa-sink: add missing header

[Paul Menzel]

Dear Eero,


thank you for you patch.

Am Donnerstag, den 31.05.2012, 07:57 +0300 schrieb eero.nurkkala at offcode.fi:
> From: Eero Nurkkala <eero.nurkkala at offcode.fi>
> 
> Compilation with -DDEBUG_TIMING fails due to a missing header:
> 
> modules/alsa/alsa-sink.c: In function 'check_left_to_play':
> modules/alsa/alsa-sink.c:453:9: warning: implicit declaration of
> function 'raise' [-Wimplicit-function-declaration]
> modules/alsa/alsa-sink.c:453:9: error: 'SIGTRAP' undeclared (first
> use in this function)

Please turn off line wrapping when pasting error messages. If you mail
client does not allow that, please switch or use `git send-email`.

> Signed-off-by: Eero Nurkkala <eero.nurkkala at offcode.fi>
> ---
>  src/modules/alsa/alsa-sink.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/src/modules/alsa/alsa-sink.c b/src/modules/alsa/alsa-sink.c
> index 066f2dd..3898191 100644
> --- a/src/modules/alsa/alsa-sink.c
> +++ b/src/modules/alsa/alsa-sink.c
> @@ -25,6 +25,7 @@
>  #endif
>  
>  #include <stdio.h>
> +#include <signal.h>

Is sorting headers in these blocks useful?
 
>  #include <asoundlib.h>

It would be great if you could resend as [PATCH v2]. You could also make
the commit summary more informational.

    alsa-sink: add missing header `signal.h`


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20120531/b157fa01/attachment.pgp>