[pulseaudio-discuss] [PATCH PA1.1 1/2] alsa-sink: add missing header

eero.nurkkala at offcode.fi eero.nurkkala at offcode.fi
Wed May 30 23:42:42 PDT 2012


Quoting Paul Menzel <paulepanter at users.sourceforge.net>:
>>  #include <stdio.h>
>> +#include <signal.h>
>
> Is sorting headers in these blocks useful?
>

Hi,

I missed the point about sorting - would you rather want the signal.h
on top of stdio.h maybe?

>>  #include <asoundlib.h>
>
> It would be great if you could resend as [PATCH v2]. You could also make
> the commit summary more informational.
>
>     alsa-sink: add missing header `signal.h`
>

Sure,

- Eero

>
> Thanks,
>
> Paul
>




More information about the pulseaudio-discuss mailing list